mbrookhart commented on a change in pull request #9873:
URL: https://github.com/apache/tvm/pull/9873#discussion_r787157315
##########
File path: src/target/source/codegen_cuda.cc
##########
@@ -1051,18 +1051,27 @@ void CodeGenCUDA::PrintWmmaScope(const std::string&
scope, DataType t, const Var
}
}
+int stoi(const std::string& str) {
+ try {
+ return std::stoi(str);
+ } catch (std::invalid_argument& e) {
+ LOG(FATAL) << "Cannot convert \"" << str << "\" to int";
+ throw;
Review comment:
I don't think you need this throw, LOG(FATAL) throws under the hood.
##########
File path: src/arith/rewrite_simplify.cc
##########
@@ -820,6 +820,10 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const
FloorDivNode* op) {
TVM_TRY_REWRITE_IF(floordiv(x * y, y), x, CanProveGreaterEqual(y.Eval(),
0));
TVM_TRY_REWRITE_IF(floordiv(y * x, y), x, CanProveGreaterEqual(y.Eval(),
0));
+ if ((floordiv(x, y)).Match(ret) && analyzer_->CanProve(x.Eval() <
y.Eval())) {
+ return 0;
+ }
+
Review comment:
I'm not sure what this is for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
