junrushao1994 commented on a change in pull request #9748:
URL: https://github.com/apache/tvm/pull/9748#discussion_r787379719
##########
File path: include/tvm/runtime/container/optional.h
##########
@@ -93,6 +93,11 @@ class Optional : public ObjectRef {
ICHECK(data_ != nullptr);
return T(data_);
}
+ /*!
+ * \return The internal object pointer with type T* for Optional<T>.
+ * \note This function do not perform not-null checking.
+ */
+ const T* get() const { return data_; }
Review comment:
The type of `T` here is an ObjectRef, instead we should use
`ContainerType` as defined a few lines above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
