manupa-arm commented on a change in pull request #9565:
URL: https://github.com/apache/tvm/pull/9565#discussion_r787589241
##########
File path: src/target/source/codegen_source_base.cc
##########
@@ -113,5 +113,60 @@ void CodeGenSourceBase::EndScope(int scope_id) {
indent_ -= 2;
}
+void CodeGenSourceBase::PrintType(DataType type, std::ostream& os) { //
NOLINT(*)
+ ICHECK_EQ(type.lanes(), 1) << "do not yet support vector types";
+ if (type.is_handle()) {
+ os << "void*";
+ return;
+ }
+ if (type.is_float()) {
+ if (type.bits() == 32) {
+ os << "float";
+ return;
+ }
+ if (type.bits() == 64) {
Review comment:
I was just moving the already existing implementation to the base class
:).
Moreover, there was a LOG(FATAL) at the bottom that should cover this case
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
