tkonolige commented on pull request #9872: URL: https://github.com/apache/tvm/pull/9872#issuecomment-1016855830
I don't know if this is my decision to make, but I see two ways forward: 1. Delay this PR until we have structured errors. This will probably take a while because there isn't anyone working on structured errors right now. 2. Hide this feature behind a `TVM_BACKTRACE_COLOR` flag. Personally I think 1 is the right way to do this but 2 might be a good stopgap. However, if we do 2 we first need to check that coloring errors does not cause issues with any of the tuning infrastructure. I know autotvm saves the errors to a log file, so you'll have to test that the colors get disabled for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
