mbs-octoml commented on pull request #8847: URL: https://github.com/apache/tvm/pull/8847#issuecomment-1016885567
I've also been surprised by our sometimes mutable, sometimes COW semantics in IRModule. However may I propose we don't merge this and, as @tqchen mentions, we solve the root problems. This is CORE-124 in the internal OctoML JIRA, in which the suggestion was to make IRModule immutable and, if worthwhile, introduce an IRModuleBuilder for use by module passes. An RFC would be first step in that process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
