tqchen commented on pull request #9848: URL: https://github.com/apache/tvm/pull/9848#issuecomment-1018075714
Looking through the change. Leaving some comments for your considerations(this is a bit subtle). From a reader pov, a natural interpreation of `value->virtual_device()` is the device that the value will reside in during rumtime. Let us say `fn` is a function. A natural interpreation of `fn->virtual_device()` could be the device that the function pointer(reference to the function) resides in. Note that is is not exactly the same interpretation as the device that the function's return value resides in, which is `fn->body->virtual_device()`, so it might be more consistent to use the later one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
