areusch commented on pull request #10014: URL: https://github.com/apache/tvm/pull/10014#issuecomment-1019575145
@kparzysz-quic i agree it can be a bit misleading. if you feel strongly about it, i'm okay with us adopting the more explicit approach. it would waste a few bytes, but we do now provide a more compact solution for the standalone deployment workflow, so perhaps that's okay now. i am curious on your take on my rationale presented in the thread Cody links above. Regardless of the strategy taken around the C struct, it's going to be a bit dangerous since we generate this structure from LLVM and C source codegen, and then try to re-interpret the structure using a different compiler. @A1245967 you'll also need to update the [LLVM codegen](https://github.com/apache/tvm/blob/main/src/target/llvm/codegen_cpu.cc#L911) and [C source codegen](https://github.com/apache/tvm/blob/main/src/target/source/source_module.cc#L193) to generate the proper structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
