mbrookhart commented on pull request #10053: URL: https://github.com/apache/tvm/pull/10053#issuecomment-1021421496
Thanks, @AndrewZhaoLuo, this is a really interesting PR! I'm not 100% sure what the long term correct approach for running these kind of ops. We can talk about Look Up Tables like this, we could do polynomial approximations over the estimated range, or we could talk about casting back to FP32. I imagine that the most performant solution is going to depend on the hardware target, some ops will be fast for lookup tables, others will do better with polynomial approximations, and others might be faster just casting back to FP32. Perhaps we should make this part of the device-dependent legalization pass, instead of canonicalization? https://github.com/apache/tvm/blob/main/python/tvm/relay/qnn/op/legalizations.py @masahi @anijain2305 Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
