areusch commented on pull request #51: URL: https://github.com/apache/tvm-rfcs/pull/51#issuecomment-1021624075
thanks @cyx-6 sorry for the delay > To be clear, the primary motivation of this RFC isn't about performance, but about usability - TVM-based compilers use PackedFunc either created by TVM or the compilers themselves. The missing piece here is that TVM's PackedFunc uses std::function internally right now, which is practically not shareable across C++ DLL boundary. Therefore, this RFC mainly focuses on stabilizing the PackedFunc into a layout-stable TVM object. I think this is the key part here. can you add this description (about `std::function` not being able to be passed across the DLL boundary) to the Motivation section? I am good with this RFC after that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
