shengxinhu commented on pull request #9767: URL: https://github.com/apache/tvm/pull/9767#issuecomment-1021832403
> @shengxinhu I'm so sorry, I somehow missed this when you pinged me. I'm approaching end of week here, but I'm throwing this on my TODO list for first thing next week. > > I'm trying to remember what I did here, this was like 18 months ago now. I think my inention was to allow constants to be used across groups, even if nodes couldn't be. While I'm digging into what's going on here, would it be possible to give me a small testcase for the issue you're hitting with pad? Hi mbrookhart , sorry for late response. Currently, check_ function in PatternPartitione must be mapped to pattern 1:1, one check_function only works for one pattern, as it needs to remember and traverse all ops in the pattern. Our target has thousands of pattern, but with several limitations: such as nn.pad with pad_value = 0. We want to use only one check_function for all patterns, which visit all sub ops in the root group expr recursively. However, the group root expr has sub ops not in the group, it can't know whether sub ops in pattern or not,. So I suggest to pass group function body in the check_function instead of root group expr. However, many tests use origin design, which is not compatible. Do you has any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
