wrongtest commented on pull request #9941: URL: https://github.com/apache/tvm/pull/9941#issuecomment-1025154111
Finally I found there are existing rules can cover pattern like `min(c1, x-c2) - min(c3, x-c4) => c4-c2`, so there is no need to add more rules for my requirement. > https://github.com/apache/tvm/blob/main/src/arith/rewrite_simplify.cc#L307-L315 However, to make these rules work, I have to call `canonical_simplify` again, to move the terms which can be cancelled together. cc @spectrometerHBH @Hzfengsy would you kindly review it again? I believe then I can turn back to pending compute_at issue of #9527. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
