Mousius commented on pull request #10101: URL: https://github.com/apache/tvm/pull/10101#issuecomment-1026064310
@Lunderberg wouldn't it be great if we worked towards being able to do that? :smile_cat: Personally I think we should encourage patches like this which improve our coding standards and follow the guidelines we set out for ourselves. Having said that, the correct approach under the Google C++ Guidelines is all data should be `_` suffixed and getters added iirc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
