altanh commented on pull request #10026: URL: https://github.com/apache/tvm/pull/10026#issuecomment-1026453174
> You might also want to read and delete this pass: https://github.com/apache/tvm/blob/main/python/tvm/relay/transform/memory_plan.py#L19. The main differences afaict is that it tries to detect dynamic/static regions then combine them before inserting kills. I'm not going to touch this since it's complimentary to the liveness analysis, but probably worth reviving this pass in C++ later to reduce the allocation overhead. That pass doesn't overlap allocations over time though so it would sort of nullify the effect of liveness analysis until static planning is added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
