areusch commented on a change in pull request #10003:
URL: https://github.com/apache/tvm/pull/10003#discussion_r797881458
##########
File path: tests/scripts/task_ci_setup.sh
##########
@@ -39,3 +39,6 @@ python3 -m pip install --user tlcpack-sphinx-addon==0.2.1
synr==0.6.0
# Ensure no stale pytest-results remain from a previous test run.
(cd build && rm -rf pytest-results)
+
+# Install tvm as a local package to allow tvmc to work
+python3 -m pip install --user -e ./python
Review comment:
hmm. we could do this, but we'd have to fix
[this](https://github.com/apache/tvm/blob/main/docker/bash.sh#L396) hack at
least for the purposes of running the demo. I guess the best way would be to
remove the PYTHONPATH override in `task_demo_microtvm.sh`.
i agree we need a venv to accurately reproduce the real-world envrionment
where TVM is installed. our tests should also all probably run against that
venv rather than with the PYTHONPATH hack. it seems like for this PR, that
would be sufficent.
Project API kind of tries to address this as well--to separate the Python
deps needed to interact with a platform from those needed for TVM. we could
solve this problem once for apps/microtvm projects and port this to use Project
API, but that does come with, well, porting this to Project API. and, there's
more to that, as there would need to be some way to specify "use tvm, but the
version being tested in CI, not the one from pip."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
