FranckQC commented on a change in pull request #9482:
URL: https://github.com/apache/tvm/pull/9482#discussion_r798122379



##########
File path: python/tvm/tir/transform/transform.py
##########
@@ -310,6 +310,15 @@ def BF16TypeLowering():
     """
     return _ffi_api.BF16TypeLowering()  # type: ignore
 
+def CommonSubexprElim(enable_cse_tir: bool = True):

Review comment:
       Many thanks for the very detailed @masahi, I really appreciate your 
comments and your time.
   Ok, so I will keep for now the boolean to disable the pass easily, and we 
can still remove it in the near future if people really don't want these 
anymore.
   
   I'm almost ready to send a final commit for this PR.
   Many thanks again!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to