Lunderberg commented on a change in pull request #10099:
URL: https://github.com/apache/tvm/pull/10099#discussion_r798677322
##########
File path: python/tvm/script/tir/ty.py
##########
@@ -44,6 +44,9 @@ def __init__(self, vtype):
self.type = vtype
def evaluate(self):
+ if isinstance(self.type, tvm.ir.Type):
Review comment:
After thinking on it, I think that it would be cleaner if the type
conversion happens during the call to `__init__`, rather than being delayed
until the `.evaluate()` call. That way, the `self.type` object has a
consistent type, regardless of whether it was initialized with a string to
represent a primitive, or was initialized with a `tvm.ir.Type` to represent
that type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
