FranckQC commented on pull request #9482: URL: https://github.com/apache/tvm/pull/9482#issuecomment-1029590772
 Alright, so now we have the following that are OK: - Both the windows and macOS builds - All the sanity check and all their syntactical checks with linters and clang-format (no change is being done by them to the code-base, yay!) Only 6 additional tests (test_lower_build_te_schedule, test_lower_build_tir_func, test_lower_build_tir_module, test_lower_build_lowered_module, test_tensor_compute1 and test_tensor_compute2) that I did not have are failing. For these ones, the CSE is doing some work, and therefore is breaking the syntactical check between the obtained TIR and the expected TIR. I'll try to check that the TIR code obtained after lowering with the CSE on is effectively what we expect, and I'll update the expected TIR with it. Or perhaps I should simply update these tests by lowering without the CSE pass (i.e. with the pass disabled)? Hoping to see that merged soon, I think we are not far! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
