elvin-n edited a comment on pull request #10239:
URL: https://github.com/apache/tvm/pull/10239#issuecomment-1041148103


   > That is understood, my main concern is a lot of code looks similar
   
   Ideologically transformations look similar, but it is unable to extend 
current transformation exactly due to its expectation of DQ->subgraph->Q 
pattern. And it is not a lot of duplication - all op conversion defined through 
`FTVMFakeQuantizationToInteger` mechanism is reused, that is great
   
   > I'm wondering if this "optional" pass can supersede the original pass.
   
   Interesting question. Probably it can work in that way as well, but should 
not be so important.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to