manupa-arm commented on a change in pull request #8509:
URL: https://github.com/apache/tvm/pull/8509#discussion_r807781188
##########
File path: include/tvm/ir/module.h
##########
@@ -349,6 +386,9 @@ class IRModuleNode : public Object {
*/
std::unordered_set<String> import_set_;
friend class IRModule;
+
+ public:
+ void ExtractConstants(BaseFunc func);
Review comment:
Agreed. I would go with O2 here as that is something we could run in the
lowering pipeline.
I think we will go with O2 here for now -- to unblock progress on other
stuff that has been blocked by this PR.
We can revisit this if this proves to be an issue (I doubt it -- I feel the
centralization of constants could also be viewed as an "optimization").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
