Icemist commented on pull request #10239: URL: https://github.com/apache/tvm/pull/10239#issuecomment-1042468685
> That is understood, my main concern is a lot of code looks similar and I'm wondering if this "optional" pass can supersede the original pass. I guess this is a slightly different approach. Not all operations are suitable for the new pass. Some operations like "add" require an explicit out_scale, which in the existing pass is taken from the quantization operation. This is possible for the existing pass because it goes from the end to the beginning of the selected subgraph. In the new pass we go from the beginning to the end. Starting from the dequantization operations and have no access to the quantization operation info at the moments of converting. Or maybe even stop halfway before we get the info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
