tmoreau89 commented on a change in pull request #10310:
URL: https://github.com/apache/tvm/pull/10310#discussion_r810361183
##########
File path: python/tvm/topi/arm_cpu/conv2d_int8.py
##########
@@ -39,10 +40,10 @@ def _get_default_config(cfg, data, kernel, strides,
padding, dilation, out_dtype
wkl = _get_conv2d_workload(data, kernel, strides, padding, dilation,
out_dtype)
is_kernel_1x1 = wkl.kernel_h == 1 and wkl.kernel_w == 1
if is_kernel_1x1:
- conv2d_generic.fallback_schedule_cpu_1x1_int8(cfg, wkl, int32_lanes=2,
num_int8_elements=4)
+ conv2d_generic.fallback_schedule_cpu_1x1_int8(cfg, wkl, int32_lanes=4,
num_int8_elements=4)
Review comment:
What's the reasoning behind this change in int32_lanes? Did we use the
wrong value all along?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
