Lunderberg commented on a change in pull request #9727:
URL: https://github.com/apache/tvm/pull/9727#discussion_r810385743
##########
File path: src/target/source/codegen_c.cc
##########
@@ -158,78 +158,52 @@ void CodeGenC::PrintSSAAssign(const std::string& target,
const std::string& src,
}
// Print a reference expression to a buffer.
-std::string CodeGenC::GetBufferRef(DataType t, const VarNode* buffer, PrimExpr
index) {
+std::string CodeGenC::GetBufferRef(DataType t, const BufferNode* buffer,
PrimExpr index) {
+ const VarNode* buffer_var = buffer->data.get();
std::ostringstream os;
- std::string vid = GetVarID(buffer);
+ std::string vid = GetVarID(buffer_var);
std::string scope;
- if (alloc_storage_scope_.count(buffer)) {
- scope = alloc_storage_scope_.at(buffer);
+ if (alloc_storage_scope_.count(buffer_var)) {
+ scope = alloc_storage_scope_.at(buffer_var);
}
- bool is_vol = IsVolatile(buffer);
- if (t.lanes() == 1) {
- if (!HandleTypeMatch(buffer, t) || is_vol) {
- os << "((";
- if (is_vol) {
- os << "volatile ";
- }
- // Scope may not be part of type.
- if (!scope.empty() && IsScopePartOfType()) {
- PrintStorageScope(scope, os);
- }
- PrintType(t, os);
- os << "*)" << vid << ')';
- } else {
- os << vid;
- }
- os << "[(";
- PrintExpr(index, os);
- os << ")";
- if (t.bits() == 4 || (t.bits() == 1 && t.is_int())) {
- os << " / " << (32 / t.bits());
- }
- os << ']';
- } else {
Review comment:
It does. The `(32 / t.bits())` in that branch is to do a computation in
terms of the type that has been cast to, rather than the type of the underlying
32-bit integer that backs the array. This same behavior comes out with the
check for the number of lanes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
