yzh119 commented on a change in pull request #10327:
URL: https://github.com/apache/tvm/pull/10327#discussion_r810583654
##########
File path: tests/python/unittest/test_tir_transform_compact_buffer_region.py
##########
@@ -505,6 +505,74 @@ def compacted_opaque_access_annotated_func(a: T.handle) ->
None:
T.store(C.data, i, T.load("float32", B.data, i))
[email protected]_func
+def sparse_read_cache(
+ A_data: T.Buffer[(819,), "float32"],
+ B: T.Buffer[(128,), "float32"],
+ A_indptr: T.Buffer[(129,), "int32"],
+ A_indices: T.Buffer[(819,), "int32"],
+) -> None:
+ for i in T.serial(128):
+ with T.block("rowsum_outer"):
+ T.reads(
+ A_indptr[i],
+ A_indptr[i + 1],
Review comment:
@Hzfengsy So there is no way we can do `T.reads(A_indptr[i], A_indptr[i
+ 2])`?
##########
File path: tests/python/unittest/test_tir_transform_compact_buffer_region.py
##########
@@ -505,6 +505,74 @@ def compacted_opaque_access_annotated_func(a: T.handle) ->
None:
T.store(C.data, i, T.load("float32", B.data, i))
[email protected]_func
+def sparse_read_cache(
+ A_data: T.Buffer[(819,), "float32"],
+ B: T.Buffer[(128,), "float32"],
+ A_indptr: T.Buffer[(129,), "int32"],
+ A_indices: T.Buffer[(819,), "int32"],
+) -> None:
+ for i in T.serial(128):
+ with T.block("rowsum_outer"):
+ T.reads(
+ A_indptr[i],
+ A_indptr[i + 1],
+ A_data[A_indptr[i] + 0 : A_indptr[i] + (A_indptr[i + 1] -
A_indptr[i])],
Review comment:
One problem with this analysis is that we cannot assume `A_indptr[i+1]
>= A_indptr[i]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
