Mousius commented on a change in pull request #10022:
URL: https://github.com/apache/tvm/pull/10022#discussion_r811011385



##########
File path: apps/microtvm/zephyr_cmsisnn/src/main.c
##########
@@ -34,7 +34,7 @@ extern float output_storage[12];
 
 extern const size_t output_len;
 
-static uint8_t g_crt_workspace[TVMGEN_DEFAULT_WORKSPACE_SIZE + 256];
+static uint8_t g_crt_workspace[TVMGEN_DEFAULT_WORKSPACE_SIZE + 512];

Review comment:
       Zephyr should have no real impact on the memory pre-allocated here as 
it's just a block in flash, this is deeply worrying as the allocator is 
configured here:
   
   
https://github.com/apache/tvm/blob/7d831e1dd34d441e9217096d0baf78e6f97c77d9/apps/microtvm/zephyr_cmsisnn/src/main.c#L62
   
   Thus the allocator itself should never go over if it's performing properly, 
something is very weird here but I agree we should investigate further when 
we've integrated USMP fully.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to