kparzysz-quic commented on a change in pull request #10302: URL: https://github.com/apache/tvm/pull/10302#discussion_r812392160
########## File path: tests/python/contrib/test_hexagon/rpc/conftest.py ########## @@ -1,31 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -import pytest - - -def pytest_addoption(parser): Review comment: I want to use serial number to distinguish running it on target (where it's a serial number of an actual device), and on simulator, where it would be a string "simulator". `ANDROID_SERIAL_NUMBER` has multiple users. If you have a better mechanism in mind for setting simulator as the execution platform, let me know. I'd like to be able to run the same `test.py` on either hardware or simulator without manual editing, so some parts of `HexagonLauncher` will need to be modified a bit (to hide the internals a bit more). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
