electriclilies commented on a change in pull request #10352:
URL: https://github.com/apache/tvm/pull/10352#discussion_r813440145



##########
File path: src/printer/relay_text_printer.cc
##########
@@ -220,9 +220,13 @@ Doc RelayTextPrinter::AllocVar(const Var& var) {
   }
   Doc val = GetUniqueName("%" + name);
   memo_[var] = val;
+  if (!var->virtual_device()->IsFullyUnconstrained()) {

Review comment:
       I guess for now, let-bound variables don't have their virtual devices 
set so it theoretically won't be triggered.. I haven't seen any issues in CI 
related to this but I could split the function into two if you'd like
   Eventually we will annotate let-bound variables and at that point we will 
have to parse the fake attrs for let bound variables




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to