gromero commented on pull request #10320: URL: https://github.com/apache/tvm/pull/10320#issuecomment-1049361537
> Thanks @gromero ! Would you mind clarifying part of your comment? > > > ... we can now pass a `Runtime()` object and a `Executor()` object > > When you write `Runtime()` and `Executor()`, are you referring to _actual_ C++/Python functions or class names? Or should I read that as pseudocode that wouldn't be literally valid in TVM? @cconvey I had the `Runtime` and `Executor` Python classes in mind yep, the ones found in the source below, which are actually mapped to the C++ code found in `./src`, via the CFFI: https://github.com/apache/tvm/blob/main/python/tvm/relay/backend/executor.py#L27 https://github.com/apache/tvm/blob/main/python/tvm/relay/backend/runtime.py#L27 and used, for instance, like in: https://github.com/apache/tvm/blob/main/tests/micro/zephyr/test_zephyr_aot.py#L69-L72 But more broadly I was just saying that if I'm not mistaken in the past the concepts of runtime and executor were not as clear as they are now, back when there wasn't the even the AOT executor and before the discussions/changes around: https://github.com/apache/tvm/pull/9352 ... and I think your patch is fixing what looks a reminiscent code of that period. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
