masahi commented on a change in pull request #10112:
URL: https://github.com/apache/tvm/pull/10112#discussion_r814240506
##########
File path: include/tvm/tir/op.h
##########
@@ -835,10 +835,18 @@ TVM_DLL PrimExpr q_multiply_shift(PrimExpr x, PrimExpr y,
PrimExpr q, PrimExpr s
Span span = Span());
// Intrinsic operators
-#define TVM_DECLARE_INTRIN_UNARY(OpName) \
- inline PrimExpr OpName(PrimExpr x, Span span = Span()) { \
- static const Op& op = Op::Get("tir." #OpName); \
- return tir::Call(x.dtype(), op, {x}, span); \
+#define TVM_DECLARE_INTRIN_UNARY(OpName) \
+ inline PrimExpr OpName(PrimExpr x, Span span = Span()) { \
+ static const Op& op = Op::Get("tir." #OpName); \
+ if (x.dtype().is_bfloat16()) { \
+ DataType srcType = x.dtype(); \
+ DataType dstType(kDLFloat, 32, srcType.lanes()); \
+ PrimExpr castX = tir::Cast(dstType, {x}, span); \
+ PrimExpr result = tir::Call(dstType, op, {castX}, span); \
+ return tir::Cast(srcType, {result}, span); \
Review comment:
Just do `tir::Cast("bfloat16", {result}, span)`. We use `camel_case`.
Can be fixed in a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
