kparzysz-quic edited a comment on pull request #8509: URL: https://github.com/apache/tvm/pull/8509#issuecomment-1050964634
> > However, FuseOps uses the Executor attribute from IR module, which has link_params taken from the original target (i.e. True). > > I am still a bit puzzled. > > https://github.com/apache/tvm/pull/8509/files#diff-8b95b87a2611e5e0c367ce17396b051fd868aa260c51ce0e50b94564fcb0e71fR1054-R1057 > > I read the above code as PassContext overriding whatever provided by the Executor. cc : @d-smirnov Line 1054: If executor is present in IRModule, set `link_params` to the value from the executor. This sets `link_params` to `True`, even though the current target is CPU (since the executor was created based on the original target "hexagon"). Line 1057: If the current config has a key "relay.FuseOps.link_params", set `link_params` to that value. Otherwise, use the value from line 1054. Here the config is empty, since `FoldConstants` creates an empty one, so the default value is used (i.e. the one from 1054). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
