masahi commented on a change in pull request #10283:
URL: https://github.com/apache/tvm/pull/10283#discussion_r816653008
##########
File path: src/target/source/source_module.cc
##########
@@ -518,6 +522,264 @@ class CSourceCrtMetadataModuleNode : public
runtime::ModuleNode {
}
};
+static std::string address_from_parts(const std::vector<std::string>& parts) {
+ std::stringstream ss;
+ for (unsigned int i = 0; i < parts.size(); ++i) {
+ if (i > 0) {
+ ss << "_";
+ }
+ ss << parts[i];
+ }
+ return ss.str();
+}
+
+class MetadataQueuer : public AttrVisitor {
+ public:
+ using QueueItem = std::tuple<std::string, runtime::metadata::MetadataBase>;
+ explicit MetadataQueuer(std::vector<QueueItem>* queue) : queue_{queue} {}
+
+ void Visit(const char* key, double* value) final {}
+ void Visit(const char* key, int64_t* value) final {}
+ void Visit(const char* key, uint64_t* value) final {}
+ void Visit(const char* key, int* value) final {}
+ void Visit(const char* key, bool* value) final {}
+ void Visit(const char* key, std::string* value) final {}
+ void Visit(const char* key, DataType* value) final {}
+ void Visit(const char* key, runtime::NDArray* value) final {}
+ void Visit(const char* key, void** value) final {}
+
+ void Visit(const char* key, ObjectRef* value) final {
+ address_parts_.push_back(key);
+ if (value->as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ auto metadata = Downcast<runtime::metadata::MetadataBase>(*value);
+ const runtime::metadata::MetadataArrayNode* arr =
+ value->as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "Is array? " << arr << std::endl;
Review comment:
Remove
##########
File path: src/target/source/source_module.cc
##########
@@ -518,6 +522,264 @@ class CSourceCrtMetadataModuleNode : public
runtime::ModuleNode {
}
};
+static std::string address_from_parts(const std::vector<std::string>& parts) {
+ std::stringstream ss;
+ for (unsigned int i = 0; i < parts.size(); ++i) {
+ if (i > 0) {
+ ss << "_";
+ }
+ ss << parts[i];
+ }
+ return ss.str();
+}
+
+class MetadataQueuer : public AttrVisitor {
+ public:
+ using QueueItem = std::tuple<std::string, runtime::metadata::MetadataBase>;
+ explicit MetadataQueuer(std::vector<QueueItem>* queue) : queue_{queue} {}
+
+ void Visit(const char* key, double* value) final {}
+ void Visit(const char* key, int64_t* value) final {}
+ void Visit(const char* key, uint64_t* value) final {}
+ void Visit(const char* key, int* value) final {}
+ void Visit(const char* key, bool* value) final {}
+ void Visit(const char* key, std::string* value) final {}
+ void Visit(const char* key, DataType* value) final {}
+ void Visit(const char* key, runtime::NDArray* value) final {}
+ void Visit(const char* key, void** value) final {}
+
+ void Visit(const char* key, ObjectRef* value) final {
+ address_parts_.push_back(key);
+ if (value->as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ auto metadata = Downcast<runtime::metadata::MetadataBase>(*value);
+ const runtime::metadata::MetadataArrayNode* arr =
+ value->as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "Is array? " << arr << std::endl;
+ if (arr != nullptr) {
+ for (unsigned int i = 0; i < arr->array.size(); i++) {
+ ObjectRef o = arr->array[i];
+ std::cout << "queue-visiting array element " << i << ": " <<
o->type_index() << " ("
+ << o.operator->() << ")" << std::endl;
Review comment:
Remove
##########
File path: src/target/source/source_module.cc
##########
@@ -518,6 +522,264 @@ class CSourceCrtMetadataModuleNode : public
runtime::ModuleNode {
}
};
+static std::string address_from_parts(const std::vector<std::string>& parts) {
+ std::stringstream ss;
+ for (unsigned int i = 0; i < parts.size(); ++i) {
+ if (i > 0) {
+ ss << "_";
+ }
+ ss << parts[i];
+ }
+ return ss.str();
+}
+
+class MetadataQueuer : public AttrVisitor {
+ public:
+ using QueueItem = std::tuple<std::string, runtime::metadata::MetadataBase>;
+ explicit MetadataQueuer(std::vector<QueueItem>* queue) : queue_{queue} {}
+
+ void Visit(const char* key, double* value) final {}
+ void Visit(const char* key, int64_t* value) final {}
+ void Visit(const char* key, uint64_t* value) final {}
+ void Visit(const char* key, int* value) final {}
+ void Visit(const char* key, bool* value) final {}
+ void Visit(const char* key, std::string* value) final {}
+ void Visit(const char* key, DataType* value) final {}
+ void Visit(const char* key, runtime::NDArray* value) final {}
+ void Visit(const char* key, void** value) final {}
+
+ void Visit(const char* key, ObjectRef* value) final {
+ address_parts_.push_back(key);
+ if (value->as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ auto metadata = Downcast<runtime::metadata::MetadataBase>(*value);
+ const runtime::metadata::MetadataArrayNode* arr =
+ value->as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "Is array? " << arr << std::endl;
+ if (arr != nullptr) {
+ for (unsigned int i = 0; i < arr->array.size(); i++) {
+ ObjectRef o = arr->array[i];
+ std::cout << "queue-visiting array element " << i << ": " <<
o->type_index() << " ("
+ << o.operator->() << ")" << std::endl;
+ if (o.as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ std::stringstream ss;
+ ss << i;
+ address_parts_.push_back(ss.str());
+ runtime::metadata::MetadataBase metadata =
Downcast<runtime::metadata::MetadataBase>(o);
+ ReflectionVTable::Global()->VisitAttrs(metadata.operator->(),
this);
+ address_parts_.pop_back();
+ }
+ }
+ } else {
+ ReflectionVTable::Global()->VisitAttrs(metadata.operator->(), this);
+ }
+
+ queue_->push_back(std::make_tuple(address_from_parts(address_parts_),
+
Downcast<runtime::metadata::MetadataBase>(*value)));
+ }
+ address_parts_.pop_back();
+ }
+
+ private:
+ std::vector<QueueItem>* queue_;
+ std::vector<std::string> address_parts_;
+};
+
+class MetadataSerializer : public AttrVisitor {
+ public:
+ static constexpr const char* kGlobalSymbol = "kTvmgenMetadata";
+ using MetadataTypeIndex = ::tvm::runtime::metadata::MetadataTypeIndex;
+
+ MetadataSerializer() : is_first_item_{true} {}
+
+ void WriteComma() {
+ if (is_first_item_) {
+ is_first_item_ = false;
+ } else {
+ code_ << ", " << std::endl;
+ }
+ }
+
+ void WriteKey(const char* key) {
+ if (key != nullptr) {
+ code_ << " /* " << key << "*/";
+ }
+ }
+
+ void Visit(const char* key, double* value) final {
+ WriteComma();
+ code_.setf(std::ios::hex | std::ios::showbase | std::ios::fixed |
std::ios::scientific,
+ std::ios::basefield | std::ios::showbase |
std::ios::floatfield);
+ code_ << *value;
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, int64_t* value) final {
+ WriteComma();
+ code_ << *value << "L";
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, uint64_t* value) final {
+ WriteComma();
+ code_ << *value << "UL";
+ WriteKey(key);
+ }
+ void Visit(const char* key, int* value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, bool* value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, std::string* value) final {
+ WriteComma();
+ code_ << "\"" << *value << "\"";
+ WriteKey(key);
+ }
+ void Visit(const char* key, void** value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, DataType* value) final {
+ WriteComma();
+ code_ << "{" << value->code() << ", " << value->bits() << ", " <<
value->lanes() << "}";
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, runtime::NDArray* value) final {
+ // TODO(areusch): probably we could consolidate --link-params here, tho...
+ ICHECK(false) << "do not support serializing NDArray as metadata";
+ }
+
+ void VisitArray(const runtime::metadata::MetadataArrayNode* array) {
+ std::cout << "visit array " << array << ": " << array->type_index << " "
<< array->struct_name
+ << "," << array->array.size() << std::endl;
+ auto old_is_first_item = is_first_item_;
+ is_first_item_ = true;
+ for (unsigned int i = 0; i < array->array.size(); ++i) { // ObjectRef o :
*(array->array)) {
+ ObjectRef o = array->array[i];
+ std::cout << "visiting array element " << i << ": " << o->type_index()
<< " ("
+ << o.operator->() << ")" << std::endl;
+ if (o->IsInstance<IntImmNode>()) {
+ int64_t i = Downcast<Integer>(o);
+ Visit(nullptr, &i);
+ continue;
+ }
+
+ if (o->IsInstance<StringObj>()) {
+ std::string s = Downcast<String>(o);
+ Visit(nullptr, &s);
+ continue;
+ }
+
+ runtime::metadata::MetadataBase metadata =
Downcast<runtime::metadata::MetadataBase>(o);
+ std::stringstream i_str;
+ i_str << i;
+ address_.push_back(i_str.str());
+ Visit(nullptr, &metadata);
+ address_.pop_back();
+ // ReflectionVTable::Global()->VisitAttrs(metadata.operator->(),
this);
+ }
+ is_first_item_ = old_is_first_item;
+ }
+
+ void Visit(const char* key, ObjectRef* value) final {
+ const runtime::metadata::MetadataArrayNode* arr =
+ value->as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "Is array? " << arr << std::endl;
Review comment:
Remove
##########
File path: src/target/source/source_module.cc
##########
@@ -518,6 +522,264 @@ class CSourceCrtMetadataModuleNode : public
runtime::ModuleNode {
}
};
+static std::string address_from_parts(const std::vector<std::string>& parts) {
+ std::stringstream ss;
+ for (unsigned int i = 0; i < parts.size(); ++i) {
+ if (i > 0) {
+ ss << "_";
+ }
+ ss << parts[i];
+ }
+ return ss.str();
+}
+
+class MetadataQueuer : public AttrVisitor {
+ public:
+ using QueueItem = std::tuple<std::string, runtime::metadata::MetadataBase>;
+ explicit MetadataQueuer(std::vector<QueueItem>* queue) : queue_{queue} {}
+
+ void Visit(const char* key, double* value) final {}
+ void Visit(const char* key, int64_t* value) final {}
+ void Visit(const char* key, uint64_t* value) final {}
+ void Visit(const char* key, int* value) final {}
+ void Visit(const char* key, bool* value) final {}
+ void Visit(const char* key, std::string* value) final {}
+ void Visit(const char* key, DataType* value) final {}
+ void Visit(const char* key, runtime::NDArray* value) final {}
+ void Visit(const char* key, void** value) final {}
+
+ void Visit(const char* key, ObjectRef* value) final {
+ address_parts_.push_back(key);
+ if (value->as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ auto metadata = Downcast<runtime::metadata::MetadataBase>(*value);
+ const runtime::metadata::MetadataArrayNode* arr =
+ value->as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "Is array? " << arr << std::endl;
+ if (arr != nullptr) {
+ for (unsigned int i = 0; i < arr->array.size(); i++) {
+ ObjectRef o = arr->array[i];
+ std::cout << "queue-visiting array element " << i << ": " <<
o->type_index() << " ("
+ << o.operator->() << ")" << std::endl;
+ if (o.as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ std::stringstream ss;
+ ss << i;
+ address_parts_.push_back(ss.str());
+ runtime::metadata::MetadataBase metadata =
Downcast<runtime::metadata::MetadataBase>(o);
+ ReflectionVTable::Global()->VisitAttrs(metadata.operator->(),
this);
+ address_parts_.pop_back();
+ }
+ }
+ } else {
+ ReflectionVTable::Global()->VisitAttrs(metadata.operator->(), this);
+ }
+
+ queue_->push_back(std::make_tuple(address_from_parts(address_parts_),
+
Downcast<runtime::metadata::MetadataBase>(*value)));
+ }
+ address_parts_.pop_back();
+ }
+
+ private:
+ std::vector<QueueItem>* queue_;
+ std::vector<std::string> address_parts_;
+};
+
+class MetadataSerializer : public AttrVisitor {
+ public:
+ static constexpr const char* kGlobalSymbol = "kTvmgenMetadata";
+ using MetadataTypeIndex = ::tvm::runtime::metadata::MetadataTypeIndex;
+
+ MetadataSerializer() : is_first_item_{true} {}
+
+ void WriteComma() {
+ if (is_first_item_) {
+ is_first_item_ = false;
+ } else {
+ code_ << ", " << std::endl;
+ }
+ }
+
+ void WriteKey(const char* key) {
+ if (key != nullptr) {
+ code_ << " /* " << key << "*/";
+ }
+ }
+
+ void Visit(const char* key, double* value) final {
+ WriteComma();
+ code_.setf(std::ios::hex | std::ios::showbase | std::ios::fixed |
std::ios::scientific,
+ std::ios::basefield | std::ios::showbase |
std::ios::floatfield);
+ code_ << *value;
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, int64_t* value) final {
+ WriteComma();
+ code_ << *value << "L";
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, uint64_t* value) final {
+ WriteComma();
+ code_ << *value << "UL";
+ WriteKey(key);
+ }
+ void Visit(const char* key, int* value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, bool* value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, std::string* value) final {
+ WriteComma();
+ code_ << "\"" << *value << "\"";
+ WriteKey(key);
+ }
+ void Visit(const char* key, void** value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, DataType* value) final {
+ WriteComma();
+ code_ << "{" << value->code() << ", " << value->bits() << ", " <<
value->lanes() << "}";
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, runtime::NDArray* value) final {
+ // TODO(areusch): probably we could consolidate --link-params here, tho...
+ ICHECK(false) << "do not support serializing NDArray as metadata";
+ }
+
+ void VisitArray(const runtime::metadata::MetadataArrayNode* array) {
+ std::cout << "visit array " << array << ": " << array->type_index << " "
<< array->struct_name
+ << "," << array->array.size() << std::endl;
+ auto old_is_first_item = is_first_item_;
+ is_first_item_ = true;
+ for (unsigned int i = 0; i < array->array.size(); ++i) { // ObjectRef o :
*(array->array)) {
+ ObjectRef o = array->array[i];
+ std::cout << "visiting array element " << i << ": " << o->type_index()
<< " ("
+ << o.operator->() << ")" << std::endl;
Review comment:
Remove
##########
File path: src/target/source/source_module.cc
##########
@@ -518,6 +522,264 @@ class CSourceCrtMetadataModuleNode : public
runtime::ModuleNode {
}
};
+static std::string address_from_parts(const std::vector<std::string>& parts) {
+ std::stringstream ss;
+ for (unsigned int i = 0; i < parts.size(); ++i) {
+ if (i > 0) {
+ ss << "_";
+ }
+ ss << parts[i];
+ }
+ return ss.str();
+}
+
+class MetadataQueuer : public AttrVisitor {
+ public:
+ using QueueItem = std::tuple<std::string, runtime::metadata::MetadataBase>;
+ explicit MetadataQueuer(std::vector<QueueItem>* queue) : queue_{queue} {}
+
+ void Visit(const char* key, double* value) final {}
+ void Visit(const char* key, int64_t* value) final {}
+ void Visit(const char* key, uint64_t* value) final {}
+ void Visit(const char* key, int* value) final {}
+ void Visit(const char* key, bool* value) final {}
+ void Visit(const char* key, std::string* value) final {}
+ void Visit(const char* key, DataType* value) final {}
+ void Visit(const char* key, runtime::NDArray* value) final {}
+ void Visit(const char* key, void** value) final {}
+
+ void Visit(const char* key, ObjectRef* value) final {
+ address_parts_.push_back(key);
+ if (value->as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ auto metadata = Downcast<runtime::metadata::MetadataBase>(*value);
+ const runtime::metadata::MetadataArrayNode* arr =
+ value->as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "Is array? " << arr << std::endl;
+ if (arr != nullptr) {
+ for (unsigned int i = 0; i < arr->array.size(); i++) {
+ ObjectRef o = arr->array[i];
+ std::cout << "queue-visiting array element " << i << ": " <<
o->type_index() << " ("
+ << o.operator->() << ")" << std::endl;
+ if (o.as<runtime::metadata::MetadataBaseNode>() != nullptr) {
+ std::stringstream ss;
+ ss << i;
+ address_parts_.push_back(ss.str());
+ runtime::metadata::MetadataBase metadata =
Downcast<runtime::metadata::MetadataBase>(o);
+ ReflectionVTable::Global()->VisitAttrs(metadata.operator->(),
this);
+ address_parts_.pop_back();
+ }
+ }
+ } else {
+ ReflectionVTable::Global()->VisitAttrs(metadata.operator->(), this);
+ }
+
+ queue_->push_back(std::make_tuple(address_from_parts(address_parts_),
+
Downcast<runtime::metadata::MetadataBase>(*value)));
+ }
+ address_parts_.pop_back();
+ }
+
+ private:
+ std::vector<QueueItem>* queue_;
+ std::vector<std::string> address_parts_;
+};
+
+class MetadataSerializer : public AttrVisitor {
+ public:
+ static constexpr const char* kGlobalSymbol = "kTvmgenMetadata";
+ using MetadataTypeIndex = ::tvm::runtime::metadata::MetadataTypeIndex;
+
+ MetadataSerializer() : is_first_item_{true} {}
+
+ void WriteComma() {
+ if (is_first_item_) {
+ is_first_item_ = false;
+ } else {
+ code_ << ", " << std::endl;
+ }
+ }
+
+ void WriteKey(const char* key) {
+ if (key != nullptr) {
+ code_ << " /* " << key << "*/";
+ }
+ }
+
+ void Visit(const char* key, double* value) final {
+ WriteComma();
+ code_.setf(std::ios::hex | std::ios::showbase | std::ios::fixed |
std::ios::scientific,
+ std::ios::basefield | std::ios::showbase |
std::ios::floatfield);
+ code_ << *value;
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, int64_t* value) final {
+ WriteComma();
+ code_ << *value << "L";
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, uint64_t* value) final {
+ WriteComma();
+ code_ << *value << "UL";
+ WriteKey(key);
+ }
+ void Visit(const char* key, int* value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, bool* value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, std::string* value) final {
+ WriteComma();
+ code_ << "\"" << *value << "\"";
+ WriteKey(key);
+ }
+ void Visit(const char* key, void** value) final {
+ WriteComma();
+ code_ << *value;
+ WriteKey(key);
+ }
+ void Visit(const char* key, DataType* value) final {
+ WriteComma();
+ code_ << "{" << value->code() << ", " << value->bits() << ", " <<
value->lanes() << "}";
+ WriteKey(key);
+ }
+
+ void Visit(const char* key, runtime::NDArray* value) final {
+ // TODO(areusch): probably we could consolidate --link-params here, tho...
+ ICHECK(false) << "do not support serializing NDArray as metadata";
+ }
+
+ void VisitArray(const runtime::metadata::MetadataArrayNode* array) {
+ std::cout << "visit array " << array << ": " << array->type_index << " "
<< array->struct_name
+ << "," << array->array.size() << std::endl;
+ auto old_is_first_item = is_first_item_;
+ is_first_item_ = true;
+ for (unsigned int i = 0; i < array->array.size(); ++i) { // ObjectRef o :
*(array->array)) {
+ ObjectRef o = array->array[i];
+ std::cout << "visiting array element " << i << ": " << o->type_index()
<< " ("
+ << o.operator->() << ")" << std::endl;
+ if (o->IsInstance<IntImmNode>()) {
+ int64_t i = Downcast<Integer>(o);
+ Visit(nullptr, &i);
+ continue;
+ }
+
+ if (o->IsInstance<StringObj>()) {
+ std::string s = Downcast<String>(o);
+ Visit(nullptr, &s);
+ continue;
+ }
+
+ runtime::metadata::MetadataBase metadata =
Downcast<runtime::metadata::MetadataBase>(o);
+ std::stringstream i_str;
+ i_str << i;
+ address_.push_back(i_str.str());
+ Visit(nullptr, &metadata);
+ address_.pop_back();
+ // ReflectionVTable::Global()->VisitAttrs(metadata.operator->(),
this);
+ }
+ is_first_item_ = old_is_first_item;
+ }
+
+ void Visit(const char* key, ObjectRef* value) final {
+ const runtime::metadata::MetadataArrayNode* arr =
+ value->as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "Is array? " << arr << std::endl;
+ if (arr != nullptr) {
+ WriteComma();
+ if (key != nullptr) {
+ address_.push_back(key);
+ }
+ code_ << address_from_parts(address_);
+ if (key != nullptr) {
+ address_.pop_back();
+ }
+ return;
+ }
+
+ runtime::metadata::MetadataBase metadata =
Downcast<runtime::metadata::MetadataBase>(*value);
+ if (key != nullptr) { // NOTE: outermost call passes nullptr key
+ address_.push_back(key);
+ }
+ ReflectionVTable::Global()->VisitAttrs(metadata.operator->(), this);
+ if (key != nullptr) { // NOTE: outermost call passes nullptr key
+ address_.pop_back();
+ }
+ }
+
+ void CodegenMetadata(::tvm::runtime::metadata::Metadata metadata) {
+ decl_ << "#include <inttypes.h>" << std::endl
+ << "#include <tvm/runtime/metadata.h>" << std::endl
+ << "#include <tvm/runtime/c_runtime_api.h>" << std::endl;
+ std::vector<MetadataQueuer::QueueItem> queue;
+ MetadataQueuer queuer{&queue};
+ queuer.Visit(kGlobalSymbol, &metadata);
+
+ for (MetadataQueuer::QueueItem item : queue) {
+ auto struct_name = std::get<0>(item);
+ auto obj = std::get<1>(item);
+ auto arr = obj.as<runtime::metadata::MetadataArrayNode>();
+ std::cout << "codegen: " << struct_name;
Review comment:
Remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
