manupa-arm commented on a change in pull request #10224:
URL: https://github.com/apache/tvm/pull/10224#discussion_r816985525
##########
File path: src/relay/backend/contrib/cmsisnn/relay_to_tir.cc
##########
@@ -267,10 +293,13 @@ class RelayToTIRVisitor : public MixedModeMutator {
// %3 = qnn.requantize(%2, %req_input_scale_scalar,
%req_input_zero_point_scalar,
// %output_scale_scalar, %output_zero_point_scalar)
// clip(%3, a_min=%min_scalar, a_max=%max_scalar)
- tir::Var input("input", DataType::Handle(8));
- tir::Var filter("filter", DataType::Handle(8));
- tir::Var bias("bias", DataType::Handle(32));
- tir::Var output("output", DataType::Handle(8));
+ BufferCreator buffer_creator_;
Review comment:
You are right! ref :
https://google.github.io/styleguide/cppguide.html#Local_Variables
##########
File path: src/relay/backend/contrib/cmsisnn/relay_to_tir.cc
##########
@@ -267,10 +293,13 @@ class RelayToTIRVisitor : public MixedModeMutator {
// %3 = qnn.requantize(%2, %req_input_scale_scalar,
%req_input_zero_point_scalar,
// %output_scale_scalar, %output_zero_point_scalar)
// clip(%3, a_min=%min_scalar, a_max=%max_scalar)
- tir::Var input("input", DataType::Handle(8));
- tir::Var filter("filter", DataType::Handle(8));
- tir::Var bias("bias", DataType::Handle(32));
- tir::Var output("output", DataType::Handle(8));
+ BufferCreator buffer_creator_;
Review comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
