mehrdadh commented on a change in pull request #10454:
URL: https://github.com/apache/tvm/pull/10454#discussion_r818172278



##########
File path: python/tvm/contrib/hexagon/build.py
##########
@@ -17,146 +17,320 @@
 
 """Defines top-level glue functions for building Hexagon."""
 
-import pathlib
+import abc
+import datetime
+import multiprocessing as mp
 import os
+import pathlib
+import signal
+import stat
 import subprocess
 from typing import Union
-import stat
-import datetime
 
 import tvm
 from ..._ffi import libinfo
 from .session import Session
 
 
-RPC_SERVER_FILES = ["tvm_rpc_android", "libtvm_runtime.so", "android_bash.sh"]
-
-HEXAGON_FILES = ["libhexagon_rpc_skel.so"]
-
-HEXAGON_RPC_DIR = None
+HEXAGON_RPC_LIB_DIR = os.environ.get("HEXAGON_RPC_LIB_DIR")

Review comment:
       maybe add default to be `None`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to