MasterJH5574 commented on a change in pull request #10079:
URL: https://github.com/apache/tvm/pull/10079#discussion_r818673222



##########
File path: src/meta_schedule/task_scheduler/task_scheduler.cc
##########
@@ -124,7 +124,7 @@ void TaskSchedulerNode::Tune() {
 
   int running_tasks = tasks.size();
   for (int task_id; (task_id = NextTaskId()) != -1;) {
-    LOG(INFO) << "Scheduler picks Task #" << task_id << ": " << 
tasks[task_id]->task_name;
+    LOG(INFO) << "Scheduler picks Task #" << task_id + 1 << ": " << 
tasks[task_id]->task_name;

Review comment:
       Hi Xiyou! I'm curious about this change. After this change the printed 
ids at several places differ (here with `+ 1` while others without.)
   
   
https://github.com/apache/tvm/blob/0c836b73ffd9669bcc416515dce6436cbd7d7ebe/src/meta_schedule/task_scheduler/task_scheduler.cc#L96
   
   
https://github.com/apache/tvm/blob/0c836b73ffd9669bcc416515dce6436cbd7d7ebe/src/meta_schedule/measure_callback/echo_statistics.cc#L228
   
   Perhaps it's better to keep them consistent :eyes:?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to