tqchen commented on a change in pull request #9727:
URL: https://github.com/apache/tvm/pull/9727#discussion_r818887820
##########
File path: include/tvm/tir/expr.h
##########
@@ -638,6 +630,22 @@ class BufferLoadNode : public PrimExprNode {
static constexpr const char* _type_key = "tir.BufferLoad";
TVM_DECLARE_FINAL_OBJECT_INFO(BufferLoadNode, PrimExprNode);
+
+ private:
+ /*! \brief Set the dtype based on the buffer/indices
+ *
+ * Usually, the BufferLoad's dtype will be the same dtype as the
+ * buffer. This may have a different number of lanes than the
+ * buffer's dtype if index values have more than 1 lane.
+ *
+ * This function should only be called during construction and after
Review comment:
Add TODO, add WithIndices function that uses LegalizeDType, which is
called by those friend classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
