leeexyz commented on pull request #10484:
URL: https://github.com/apache/tvm/pull/10484#issuecomment-1058876349


   @haoyang9804 You can find the Sanity Check Log 
[here](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-10484/5/pipeline).
   
   change 
   
   
   
   
   
   
   ```c++
   [2022-03-04T06:18:11.419Z] -    ICHECK(!(pa && pa->dtype.is_uint() && 
pa->value == 0U && b.dtype().is_uint())) << \
   [2022-03-04T06:18:11.419Z] -     "Checked failed. Minuend 's value is 0U and 
it's dtype is uint " << \
   [2022-03-04T06:18:11.419Z] -     "while Subtrahend's dtype is uint; which 
will cause a negative unit";
   ```
   to
   ```c++
   [2022-03-04T06:18:11.419Z] +    ICHECK(!(pa && pa->dtype.is_uint() && 
pa->value == 0U && b.dtype().is_uint()))
   [2022-03-04T06:18:11.419Z] +        << "Checked failed. Minuend 's value is 
0U and it's dtype is uint "
   [2022-03-04T06:18:11.419Z] +        << "while Subtrahend's dtype is uint; 
which will cause a negative uint";
   ```
   
   You'd better run the check locally before sending a PR.
   ```bash
   bash ./tests/scripts/task_lint.sh
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to