junrushao1994 commented on a change in pull request #10470:
URL: https://github.com/apache/tvm/pull/10470#discussion_r819346759
##########
File path: include/tvm/meta_schedule/integration.h
##########
@@ -215,6 +215,9 @@ class ApplyHistoryBest : public MetaScheduleContext {
ApplyHistoryBestNode);
};
+Optional<ObjectRef> ContextQueryInsideWithScope(runtime::String task_name,
IRModule mod,
+ Target target,
+ Optional<Array<IRModule>>
dispatched);
Review comment:
Instead of creating a new global method, let's directly call
`MetaScheduleContext::QueryInsideWithScope`
##########
File path: src/te/operation/create_primfunc.h
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef TVM_TE_OPERATION_CREATE_PRIMFUNC_H_
+#define TVM_TE_OPERATION_CREATE_PRIMFUNC_H_
+
+#include <tvm/runtime/container/array.h>
+#include <tvm/te/tensor.h>
+#include <tvm/tir/function.h>
+
+namespace tvm {
+namespace tir {
+
+PrimFunc CreatePrimFuncFromOutputs(const Array<te::Tensor>& outputs);
Review comment:
Let's expose two APIs in `include/tvm/te/operation.h`:
- CreatePrimFunc
- CreatePrimFuncFromOutputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
