masahi commented on pull request #10474: URL: https://github.com/apache/tvm/pull/10474#issuecomment-1059452885
From my recent work on vnni dense, I remember that if I don't have `is_fallback` code path, some random (?) value was chosen to instantiate my schedule. So things should run I believe without `is_fallback`. I think `is_fallback` is mostly for the case where autotvm is not used and developers want to apply more sensible default values than the ones chosen arbitrary by autotvm. I think the question is: are tophub schedules supposed to be better than those hand picked params in fallback schedules? If the answer is not a definite yes, I'm inclined to remove tophub altogether and possibly port their params to whatever `_get_default_config` is doing. So how about this: We go ahead with this PR and remove tophub. If later someone complains about perf regression, which means they rely on tophub, we port tophub params to `_get_default_config`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
