Lunderberg commented on a change in pull request #10520:
URL: https://github.com/apache/tvm/pull/10520#discussion_r821098093



##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -73,10 +84,19 @@ class StackSizeChecker : public StmtExprVisitor {
       return MakeShape(op);
     } else if (op->op.same_as(builtin::tvm_stack_make_array())) {
       return MakeArray(op);
+    } else if (op->op.same_as(builtin::mem_copy())) {
+      return MakeMemCopy(op);

Review comment:
       I also figured that by having the `MakeMemCopyHelper` be shared between 
`StackSizeChecker` and `BuiltInLower` makes it harder for them to get out of 
sync in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to