manupa-arm commented on a change in pull request #10518:
URL: https://github.com/apache/tvm/pull/10518#discussion_r821609823
##########
File path: tests/python/relay/aot/aot_test_utils.py
##########
@@ -731,130 +733,129 @@ def run_and_check(
This method uses the original test data and compiled runtime.Modules
to run in the test runner to verify the results.
"""
+ tmpdir = tempfile.TemporaryDirectory() if test_dir is None else
contextlib.surpress()
Review comment:
Should not this be
https://docs.python.org/3/library/contextlib.html#contextlib.suppress ?
Also why do we need to suppress execeptions here ?
I think a slightly better approach would be to make the body of "with" to be
wrapped in a function that accepts base_path, where the dir could be provided
within a "with" if test_dir is None. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
