gromero edited a comment on pull request #10504:
URL: https://github.com/apache/tvm/pull/10504#issuecomment-1060706261


   > Hi, @gromero I have correct my PR's format, but what the tvm-ci/pr-merge 
error means?
   
   Hi @shukun-ziqiangxu . In this case the `tvm-ci/pr-merge` error points to a 
lint error in your commit. When that happens the linter shows you a diff with 
the change that must be applied to your code so the lint error is fixed, in 
that case:
   
   ```
   [2022-03-06T17:31:36.897Z] --- tests/python/frontend/pytorch/test_forward.py 
2022-03-06 17:29:46.847569 +0000
   [2022-03-06T17:31:36.897Z] +++ tests/python/frontend/pytorch/test_forward.py 
2022-03-06 17:31:35.913957 +0000
   [2022-03-06T17:31:36.897Z] @@ -4176,11 +4176,11 @@
   [2022-03-06T17:31:36.897Z]              return 
torch.nn.functional.grid_sample(
   [2022-03-06T17:31:36.897Z]                  input=x,
   [2022-03-06T17:31:36.897Z]                  grid=y,
   [2022-03-06T17:31:36.897Z]                  mode=self._method,
   [2022-03-06T17:31:36.897Z]                  padding_mode=self._padding_mode,
   [2022-03-06T17:31:36.897Z] -                align_corners=self._align_corners
   [2022-03-06T17:31:36.897Z] +                
align_corners=self._align_corners,
   [2022-03-06T17:31:36.897Z]              )
   [2022-03-06T17:31:36.897Z]  
   [2022-03-06T17:31:36.897Z]      methods = ["nearest", "bilinear", "bicubic"]
   [2022-03-06T17:31:36.897Z]      padding_modes = ["zeros", "border", 
"reflection"]
   [2022-03-06T17:31:36.897Z]      align_corners = [True, False]
   ```
   
   Last lines from: 
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-10504/1/pipeline
   
   In that case the error is that a comma is missing after the 
`align_corners=self._align_corners` parameter that needs to get added to 
satisfy the linter.
   
   You can also run the linter locally (which is usually faster than the CI 
run, so I recommend you running the linter locally to check your code before 
submitting it to the CI) by the following command executed from TVM's root tree:
   
   `$ docker/bash.sh tlcpack/ci-lint:v0.68 ./tests/scripts/task_lint.sh`
   
   After you fix it you can amend  (`git commit --amend`) and `git push 
--force`  to the same branch you used to create the PR (i.e 
https://github.com/shukun-ziqiangxu/tvm/tree/shukun-xzq-main) or just commit 
the fix on top of the 
https://github.com/apache/tvm/pull/10504/commits/22d7c193536001425f7616176cfbc718506f3131
 and do a `git push` without any force. Either way the CI will be retriggered 
in the existing PR (no need to create an additional PR) and the CI tests will 
be reinitialized with your lint fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to