Lunderberg commented on a change in pull request #10514:
URL: https://github.com/apache/tvm/pull/10514#discussion_r821796757
##########
File path: src/target/llvm/codegen_cpu.cc
##########
@@ -606,7 +606,9 @@ void CodeGenCPU::UnpackClosureData(TypedPointer cdata,
const Array<Var>& vfields
llvm::Type* field_type = cdata.type->getStructElementType(i);
llvm::Value* field_addr =
builder_->CreateInBoundsGEP(cdata.type, cdata.addr, {ConstInt32(0),
ConstInt32(i)});
- (*vmap)[vfields[i].get()] = builder_->CreateLoad(field_type, field_addr);
+ llvm::Value* load = builder_->CreateLoad(field_type, field_addr);
Review comment:
Thank you, that definitely makes it cleaner. Updated here and in
CreateParallelLaunch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
