csullivan commented on pull request #10532: URL: https://github.com/apache/tvm/pull/10532#issuecomment-1063110308
@adstraw's intention with adding these tests was to allow for unit testing of some of the C++ classes that would run pre-commit. Of course in production they run on Hexagon where custom logging is needed, but he has found it useful to have some of these unit tests running on x86 during commit time. If @adstraw prefers to keep these checks would it be acceptable to only enable custom logging when those sources are built for Hexagon? ``` #if defined(__hexagon__) #define TVM_LOG_CUSTOMIZE 1 #endif ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
