areusch commented on a change in pull request #10539:
URL: https://github.com/apache/tvm/pull/10539#discussion_r823205516
##########
File path: tests/scripts/task_build.py
##########
@@ -32,6 +32,7 @@
parser.add_argument("--sccache-bucket", required=False, help="sccache
bucket name")
parser.add_argument("--num-executors", required=True, help="number of
Jenkins executors")
parser.add_argument("--build-dir", default="build", help="build folder")
+ parser.add_argument("--target", help="optional build target")
Review comment:
maybe --cmake-target?
##########
File path: docker/bash.sh
##########
@@ -349,7 +359,7 @@ done
# Use nvidia-docker for GPU container. If nvidia-docker is not
# available, fall back to using "--gpus all" flag, requires docker
# version 19.03 or higher.
-if [[ "${DOCKER_IMAGE_NAME}" == *"gpu"* || "${DOCKER_IMAGE_NAME}" == *"cuda"*
]]; then
+if [ "$USE_GPU" == "true" ] && [[ "${DOCKER_IMAGE_NAME}" == *"gpu"* ||
"${DOCKER_IMAGE_NAME}" == *"cuda"* ]]; then
Review comment:
can we use one [[ ]] style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
