masahi commented on a change in pull request #10543: URL: https://github.com/apache/tvm/pull/10543#discussion_r824581378
########## File path: include/tvm/runtime/spsc_queue.h ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#ifndef TVM_RUNTIME_SPSC_QUEUE_H_ +#define TVM_RUNTIME_SPSC_QUEUE_H_ +#include <cstddef> +#include <thread> +#define read_barrier() std::atomic_thread_fence(std::memory_order_acquire) +#define write_barrier() std::atomic_thread_fence(std::memory_order_release) Review comment: use inlined function ########## File path: src/runtime/pipeline/pipeline_struct.h ########## @@ -739,6 +897,45 @@ class BackendRuntime { NDArray data = get_output_(idx); return CreateNDArrayFromDLTensor(const_cast<DLTensor*>(data.operator->())); } + /*! + * \brief Generate the ID of a input queue. Review comment: an input ########## File path: src/runtime/pipeline/pipeline_struct.h ########## @@ -97,23 +128,23 @@ class DataNotify { /*!\brief Whether the thread should exit or not.*/ std::atomic<bool> exit_state_{false}; /*! - * \brief The 'ModuleInterfaceID' in which the data was ready and triggered this - * notification. + * \brief The 'ModuleInterfaceID' of a interface which is going to receive the notification Review comment: an interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
