elvin-n commented on a change in pull request #10558:
URL: https://github.com/apache/tvm/pull/10558#discussion_r825730577
##########
File path: src/tir/transforms/texture_flatten.cc
##########
@@ -115,8 +115,9 @@ class TextureFlattener : public TextureLoweringBase {
size_t axis = DefaultTextureLayoutSeparator(op->bounds.size(),
storage_scope);
auto texture =
ApplyTexture2DFlattening<PrimExpr>(ShapeFromRange{op->bounds},
op->bounds.size(), axis);
- Array<PrimExpr> args = {texture.width, texture.height};
- stmt = LetStmt(buffer_var, Call(buffer_var.dtype(),
builtin::texture2d_alloca(), args), body);
+ Array<PrimExpr> args = {StringImm(storage_scope), 2, texture.width,
texture.height};
Review comment:
@csullivan just verified end-to-end scenario on scout adreno branch
rebased to master with changes from this PR - performance and accuracy is good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
