Lunderberg commented on a change in pull request #10558:
URL: https://github.com/apache/tvm/pull/10558#discussion_r825955636
##########
File path: src/runtime/hexagon/hexagon/hexagon_device_api_v2.cc
##########
@@ -119,6 +119,13 @@ void HexagonDeviceAPIv2::FreeWorkspace(Device dev, void*
data) {
workspace_allocations_.erase(it);
}
+void* HexagonDeviceAPIv2::AllocVtcmWorkspace(Device dev, int ndim, const
int64_t* shape,
+ DLDataType dtype,
Optional<String> mem_scope) {
+ return AllocDataSpace(dev, ndim, shape, dtype, mem_scope);
Review comment:
Thank you. I have difficulty remembering how C++ handles function
overloads of virtual functions, if a subclass only overrides some of the
overloads, and need to check whenever I run into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
