cgerum commented on pull request #60:
URL: https://github.com/apache/tvm-rfcs/pull/60#issuecomment-1066897007


   > One thing I'd like anwsered here what sort of control it will allow on the 
passes run there : MergeComposite, AnnotateTarget, MergeCompilerRegions and 
ParititionGraph.
   
   So far we had planned to standardize on MergeComposite, AnnotateTarget, 
MergeCompilerRegions and ParititionGraph. To get a better overview I extracted 
the partitioning flows of existing BYOC targets:
   
   |BYOC Backend    | Pre Partition Passes                                      
                              |  Partition                                      
                             |  Post Partition Passes                           
                                          |
   
|----------------|-----------------------------------------------------------------------------------------|------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------|
   |arm_compute_lib | InferType,                                                
                              |  MergeComposite, AnnotateTarget, PartitionGraph 
                             |                                                  
                                          |
   |bnns            | InferType, FoldConstant, FoldScaleAxis, DynamicToStatic, 
AlterOpLayout, FoldConstant,   |  MergeComposite, AnnotateTarget, 
PartitionGraph                              |                                   
                                                         |
   |cmsisnn         |                                                           
                              |  MergeComposite, AnnotateTarget, 
PartitionGraph,                             | GenerateCMSISNNConstants, 
ScalarToTensorConstants, ExtractConstantsFromPartitionedFunction |
   |cutlass         | SimplifyInference, FoldConstant, FoldScaleAxis,           
                              |  MergeComposite, AnnotateTarget, PartitionGraph 
                             |                                                  
                                          |
   |dnnl            |                                                           
                              |  MergeComposite, AnnotateTarget, 
MergeCompilerRegions, PartitionGraph        |                                   
                                                         |
   |ethosu          |                                                           
                              |  MergeComposite, AnnotateTarget, 
MergeCompilerRegions, PartitionGraph,       |   preprocess_ext_io               
                                                         |
   |tensorrt        | RemoveDropoutPass, RemoveUnusedFunctions, ConvertLayout, 
FoldConstant,                  |  AnnotateTarget, MergeCompilerRegions, 
PartitionGraph                        |                                         
                                                   |
   |vitis_ai        | RemoveUnusedFunctions, ConvertLayout, FoldConstant, 
InferType,                          |  ("VitisAIAnnotationPass"), 
MergeCompilerRegions, PartitionGraph,            |   RemoveUnusedFunctions, 
ConvertLayout, FoldConstant                                       |
   
   Looking at the existing backends it might make sense to make 
MergeCompilerRegions optional. We probably do not want to support custom 
compiler annotations as used in `vitis_ai` target. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to