adstraw commented on pull request #10558: URL: https://github.com/apache/tvm/pull/10558#issuecomment-1067317479
> My only comment is about naming conventions in `device_api`: there is snake_case (e.g. `device_api.hexagon.mem_copy`), but here we're introducing CamelCase: `device_api.hexagon.AllocNd`. Should we have a uniform naming style? Good point. If it's all right with you let's clean this up in the subsequent PR that will be needed to clean up the `TODO` items and enable nd allocations through the Hexagon Device API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
