junrushao1994 commented on a change in pull request #10578:
URL: https://github.com/apache/tvm/pull/10578#discussion_r826421575
##########
File path: include/tvm/meta_schedule/integration.h
##########
@@ -86,14 +86,11 @@ class MetaScheduleContextNode : public runtime::Object {
* \param target Target info
* \param dispatched A list of low-level IRs that the high-level IR could
potentially dispatch to.
* NullOpt means the dispatch needs to be done in the
context.
- * \return There are different types of the output
- * 1) NullOpt if there is no feedback hint
- * 2) tir::PrimFunc if `mod` should be lowered to a PrimFunc
- * 3) relay::Function if `mod` should be dispatched to BYOC workflow
- * 4) IRModule for unified dispatch
+ * \return IRModule Currently we only have to return tir::PrimFunc, but we
wrap it
+ * under IRModule for more general future use.
*/
- virtual Optional<ObjectRef> Query(runtime::String task_name, IRModule mod,
Target target,
- Optional<Array<IRModule>> dispatched) = 0;
+ virtual IRModule Query(runtime::String task_name, IRModule mod, Target
target,
Review comment:
Thanks for refactoring this interface! On the other hand, the interface
itself might be unnecessary any more after the refactoring :-) Perhaps we would
love to refactor this completely some time after this PR is merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
