wrongtest commented on pull request #10582: URL: https://github.com/apache/tvm/pull/10582#issuecomment-1067470836
Thanks for the remind @tqchen ! For the `data_alignment` , I have an extra question that whether the `data_alignment` is about the `data` ptr address or about the first element's address? If the former, I think we should ensure the alignment property every time we create alias buffer to existing buffer vars, no matter whether the `elem_offset` is non-zero. I would like to change the alignment handling in `StorageRewrite` pass since it has explicit buffer aliasing impl code path. > https://github.com/apache/tvm/blob/2f7bb58377736bec2a15b45fa730e6f5b73605fb/include/tvm/tir/buffer.h#L84-L90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
